Skip to content

move panorama's to fancy menu's build in panorama tech#435

Open
UltraPuPower wants to merge 4 commits intoTheta-1-Mainfrom
fancy_menu_panoramas
Open

move panorama's to fancy menu's build in panorama tech#435
UltraPuPower wants to merge 4 commits intoTheta-1-Mainfrom
fancy_menu_panoramas

Conversation

@UltraPuPower
Copy link
Copy Markdown
Contributor

Title says it all tbh
As per discord

Cycling panorama's inside the same layout seems to be impossible: ref > Fancymenu discord support

Possible issues/reasons we wouldn't want to do this

  • Adding a new panorama becomes a bit more of a hassle, nothing much but small annoyance
  • Changing Main Menu becomes more time consuming as you will have to sync across all layouts
  • Slight lag spike when swapping menu's

Last item can possibly be mitigated by setting randomonlyfirsttime to true, but that would mean swapping a panorama by simplying entering and exiting a menu is no longer possible, and the panorama will only be picked at game launch.

To see what I mean with slight lag spike, just load up the branch and go to singleplayer and back to main menu a few times

Copy link
Copy Markdown
Contributor

@KillLaAqua KillLaAqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file commit farming tsk tsk

lgtm

@KillLaAqua
Copy link
Copy Markdown
Contributor

@UltraPuPower need to fix merge errors unless it is just being stinky (need another party to confirm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants